Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.13 ]Bump to latest of GO SDK for CE #2222

Merged

Conversation

matzew
Copy link
Member

@matzew matzew commented Mar 13, 2024

Changes

  • 🧹 Update to latest of CloudEvents SDK for GO

/kind

Fixes #

Release Note

- :broom: Update to latest of CloudEvents SDK for GO

Docs


Signed-off-by: Matthias Wessendorf <[email protected]>
Copy link

knative-prow bot commented Mar 13, 2024

@matzew: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

  • 🧹 Update to latest of CloudEvents SDK for GO

/kind

Fixes #

Release Note

- :broom: Update to latest of CloudEvents SDK for GO

Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot requested review from dsimansk and navidshaikh March 13, 2024 09:43
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 13, 2024
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.80%. Comparing base (a700b89) to head (63a5e78).

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.13    #2222      +/-   ##
================================================
+ Coverage         60.86%   63.80%   +2.94%     
================================================
  Files               108      124      +16     
  Lines             13919    14437     +518     
================================================
+ Hits               8472     9212     +740     
+ Misses             4600     4315     -285     
- Partials            847      910      +63     
Flag Coverage Δ
e2e-test 37.32% <ø> (?)
e2e-test-oncluster 30.58% <ø> (+0.10%) ⬆️
e2e-test-oncluster-runtime 26.82% <ø> (?)
e2e-test-runtime-go 25.54% <ø> (?)
e2e-test-runtime-node 26.57% <ø> (?)
e2e-test-runtime-python 26.57% <ø> (?)
e2e-test-runtime-quarkus 26.68% <ø> (?)
e2e-test-runtime-rust 25.57% <ø> (?)
e2e-test-runtime-springboot 25.71% <ø> (?)
e2e-test-runtime-typescript 26.68% <ø> (?)
integration-tests 51.84% <ø> (+2.03%) ⬆️
unit-tests-macos-latest 48.85% <ø> (ø)
unit-tests-ubuntu-latest 49.59% <ø> (ø)
unit-tests-windows-latest 48.87% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matzew
Copy link
Member Author

matzew commented Mar 13, 2024

/cherry-pick release-1.12

@knative-prow-robot
Copy link

@matzew: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dsimansk
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2024
Copy link

knative-prow bot commented Mar 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2024
@dsimansk
Copy link
Contributor

/cherry-pick release-1.12

I've tried from main to release-1.13 and it failed to cherry-pick due to conflicts. Hoping for the best here.

@knative-prow knative-prow bot merged commit bc40ec0 into knative:release-1.13 Mar 13, 2024
38 checks passed
@knative-prow-robot
Copy link

@matzew: #2222 failed to apply on top of branch "release-1.12":

Applying: dizzy: Bump to latest of GO SDK for CE
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
Falling back to patching base and 3-way merge...
Auto-merging go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 dizzy: Bump to latest of GO SDK for CE
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants