-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow sub-pkgs in Go functions #2523
fix: allow sub-pkgs in Go functions #2523
Conversation
Signed-off-by: Matej Vašek <[email protected]>
@matejvasek: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2523 +/- ##
==========================================
+ Coverage 61.43% 66.86% +5.43%
==========================================
Files 130 130
Lines 15479 12048 -3431
==========================================
- Hits 9509 8056 -1453
+ Misses 5029 3014 -2015
- Partials 941 978 +37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Matej Vašek <[email protected]>
Signed-off-by: Matej Vašek <[email protected]>
Signed-off-by: Matej Vašek <[email protected]>
@lkingland at three places in the code |
PTAL @lkingland |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
/kind
Fixes #
Release Note
Docs