Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce branch on test remote repository #2540

Merged

Conversation

jrangelramos
Copy link
Contributor

@jrangelramos jrangelramos commented Oct 11, 2024

Changes

  • 🧹 Set branch on remote repository test.
  • It also contains a fix environment error on python test-template run on GitHub action

/kind cleanup

@knative-prow knative-prow bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 11, 2024
@knative-prow knative-prow bot requested review from dsimansk and nainaz October 11, 2024 01:19
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 11, 2024
@jrangelramos jrangelramos requested review from matzew and matejvasek and removed request for nainaz October 11, 2024 01:19
@jrangelramos
Copy link
Contributor Author

This will fix errors on midstream CI (oncluster builds)

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.94%. Comparing base (59aa11c) to head (6095531).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2540      +/-   ##
==========================================
+ Coverage   58.94%   66.94%   +7.99%     
==========================================
  Files         130      130              
  Lines       15465    12036    -3429     
==========================================
- Hits         9116     8057    -1059     
+ Misses       5440     3007    -2433     
- Partials      909      972      +63     
Flag Coverage Δ
e2e-test 36.55% <ø> (?)
e2e-test-oncluster 33.89% <ø> (+0.04%) ⬆️
e2e-test-oncluster-runtime 29.69% <ø> (?)
e2e-test-runtime-go 26.59% <ø> (?)
e2e-test-runtime-node 26.00% <ø> (?)
e2e-test-runtime-python 25.98% <ø> (?)
e2e-test-runtime-quarkus 26.08% <ø> (?)
e2e-test-runtime-rust 25.12% <ø> (?)
e2e-test-runtime-springboot 25.16% <ø> (?)
e2e-test-runtime-typescript 26.07% <ø> (?)
integration-tests 53.08% <ø> (+2.37%) ⬆️
unit-tests 51.65% <ø> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2024
Copy link

knative-prow bot commented Oct 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrangelramos, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jrangelramos,matzew]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2024
Makefile Outdated Show resolved Hide resolved
@jrangelramos jrangelramos force-pushed the fix-test-remote-repo-for-prow-ci branch from ffdf6fc to f2e3e78 Compare October 11, 2024 13:11
@matejvasek
Copy link
Contributor

cd templates/python/cloudevents && python -m venv .venv && source .venv/bin/activate && pip3 install -r requirements.txt && python3 test_func.py && rm -rf __pycache__
/bin/sh: 1: python: not found
make: *** [Makefile:155: test-python] Error 127

@jrangelramos jrangelramos force-pushed the fix-test-remote-repo-for-prow-ci branch 2 times, most recently from 93234bb to c6af33c Compare October 11, 2024 13:46
@matzew
Copy link
Member

matzew commented Oct 11, 2024

/test unit-tests

@jrangelramos jrangelramos force-pushed the fix-test-remote-repo-for-prow-ci branch 2 times, most recently from c67b392 to d2ee9f2 Compare October 11, 2024 14:20
@matejvasek
Copy link
Contributor

/test unit-tests

@jrangelramos jrangelramos force-pushed the fix-test-remote-repo-for-prow-ci branch 2 times, most recently from 3978431 to ee4a452 Compare October 11, 2024 17:19
@jrangelramos jrangelramos force-pushed the fix-test-remote-repo-for-prow-ci branch from ee4a452 to 6095531 Compare October 11, 2024 17:44
@jrangelramos
Copy link
Contributor Author

@matzew @matejvasek can you please re-lgtm

@matejvasek
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2024
@knative-prow knative-prow bot merged commit b3b038b into knative:main Oct 12, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants