-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rm f symlink #2548
base: main
Are you sure you want to change the base?
Rm f symlink #2548
Conversation
Added a new FileSystem that evaluates/expands Go templates from *.ftmpl files in the base filesystem. For example if the base filesystem contains file go.mod.ftmpl then the new resultant FS will contain go.mod file instead, and the file would be result of template execution with templateData as the template data. Signed-off-by: Matej Vašek <[email protected]>
Now the path to user function code is directly in go.mod. Signed-off-by: Matej Vašek <[email protected]>
@matejvasek: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2548 +/- ##
===========================================
- Coverage 61.47% 45.61% -15.86%
===========================================
Files 130 110 -20
Lines 15465 14828 -637
===========================================
- Hits 9507 6764 -2743
- Misses 5021 7236 +2215
+ Partials 937 828 -109
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Changes
/kind
Fixes #
Release Note
Docs