Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rm f symlink #2548

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Rm f symlink #2548

wants to merge 2 commits into from

Conversation

matejvasek
Copy link
Contributor

Changes

/kind

Fixes #

Release Note


Docs


Added a new FileSystem that evaluates/expands Go templates from *.ftmpl files in the base filesystem.
For example if the base filesystem contains file go.mod.ftmpl then the new resultant FS will contain go.mod file instead,
and the file would be result of template execution with templateData as the template data.

Signed-off-by: Matej Vašek <[email protected]>
Now the path to user function code is directly in go.mod.

Signed-off-by: Matej Vašek <[email protected]>
Copy link

knative-prow bot commented Oct 21, 2024

@matejvasek: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

knative-prow bot commented Oct 21, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 21, 2024
Copy link

knative-prow bot commented Oct 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from dsimansk and vyasgun October 21, 2024 19:02
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 67.39130% with 30 lines in your changes missing coverage. Please review.

Project coverage is 45.61%. Comparing base (6c17586) to head (8e5fb4d).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/filesystem/filesystem.go 66.25% 20 Missing and 7 partials ⚠️
pkg/scaffolding/scaffold.go 75.00% 2 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (6c17586) and HEAD (8e5fb4d). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (6c17586) HEAD (8e5fb4d)
1 0
unit-tests-macos-latest 1 0
unit-tests-ubuntu-latest 1 0
integration-tests 1 0
unit-tests-windows-latest 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2548       +/-   ##
===========================================
- Coverage   61.47%   45.61%   -15.86%     
===========================================
  Files         130      110       -20     
  Lines       15465    14828      -637     
===========================================
- Hits         9507     6764     -2743     
- Misses       5021     7236     +2215     
+ Partials      937      828      -109     
Flag Coverage Δ
e2e-test 36.06% <67.39%> (-0.53%) ⬇️
e2e-test-oncluster 32.72% <0.00%> (-1.16%) ⬇️
e2e-test-oncluster-runtime 28.49% <0.00%> (?)
e2e-test-runtime-go 26.65% <67.39%> (?)
e2e-test-runtime-node 25.71% <0.00%> (?)
e2e-test-runtime-python 25.71% <0.00%> (?)
e2e-test-runtime-quarkus 25.86% <0.00%> (?)
e2e-test-runtime-rust 24.87% <0.00%> (?)
e2e-test-runtime-springboot 24.91% <0.00%> (?)
e2e-test-runtime-typescript 25.82% <0.00%> (?)
integration-tests ?
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 26, 2024
@knative-prow-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants