Fix authorization for buildpack builder periodic task #2622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
approved
matejvasek
requested review from
matzew,
jrangelramos,
gauron99 and
lkingland
and removed request for
dsimansk and
vyasgun
matejvasek
changed the title
matejvasek
force-pushed
the
fix-bp-auth
branch
3 times, most recently
from
11a4161 to
18f059d
Compare
Fixed authorization by setting keychain for the pack client. This is required since recently we set pull policy to "always". Signed-off-by: Matej Vašek <[email protected]>
matejvasek
force-pushed
the
fix-bp-auth
branch
from
18f059d to
c0e760a
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matejvasek, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2622 +/- ##
==========================================
+ Coverage 64.15% 65.42% +1.26%
==========================================
Files 130 130
Lines 15518 15518
==========================================
+ Hits 9956 10152 +196
+ Misses 4623 4389 -234
- Partials 939 977 +38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed authorization by setting keychain for the pack client.
This is required since recently we set pull policy to "always" recently.