-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for hostPath #15648
base: main
Are you sure you want to change the base?
Add support for hostPath #15648
Conversation
Hi @amarflybot. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15648 +/- ##
==========================================
- Coverage 83.51% 83.48% -0.03%
==========================================
Files 219 219
Lines 17427 17473 +46
==========================================
+ Hits 14554 14588 +34
- Misses 2502 2508 +6
- Partials 371 377 +6 ☔ View full report in Codecov by Sentry. |
a821b44
to
e1c0c42
Compare
This needs fix. |
/ok-to-test |
hack/schemapatch-config.yaml
Outdated
# Part of a feature flag - so we want to omit the schema and preserve unknown fields | ||
- kubebuilder:validation:DropProperties | ||
- kubebuilder:pruning:PreserveUnknownFields | ||
# Part of a feature flag - so we want to omit the schema and preserve unknown fields |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove additional space?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Fixed |
kind: Revision | ||
plural: revisions | ||
singular: revision | ||
kind: Service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the revision file this should not be changed.
@@ -1728,4 +1732,4 @@ spec: | |||
description: |- | |||
URL holds the url that will distribute traffic over the provided traffic targets. | |||
It generally has the form http[s]://{route-name}.{route-namespace}.{cluster-level-suffix} | |||
type: string | |||
type: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A new line is missing.
/retest |
@amarflybot could you update the description and add release notes. Also we need a follow up PR at the knative/docs repo to document this addition. |
I have added. Will that do ? |
/lgtm /hold for @dprotaso for any additional comments. |
I would add also that this is behind a flag as it is not the default mode. |
/retest |
1 similar comment
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amarflybot, skonto The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
@dprotaso hi, gentle ping. |
Fixes #15546
Description
This feature introduces support for the hostPath volume type in Knative Serving, enabling users to mount directories from the host node’s filesystem into their service containers. This allows direct access to node-specific data or preloaded resources like certificates, enhancing flexibility while retaining Knative’s serverless capabilities.
Proposed Changes
Release Note