Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(STONEBLD-2371): Multi platform controller tests #1134

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

stuartwdouglas
Copy link
Contributor

Add in-repo tests for multi platform controller

Description

This is part of a set of changes that should allow the multi platform controller to be tested in-repo.

Additional PRs are:
redhat-appstudio/infra-deployments#3619
openshift/release#51236

Issue ticket number and link

https://issues.redhat.com/browse/STONEBLD-2371

@openshift-ci openshift-ci bot requested review from ascerra and mkosiarc April 23, 2024 08:56
@stuartwdouglas stuartwdouglas changed the title STONEBLD-2371 Multi platform controller tests feat(STONEBLD-2371): Multi platform controller tests Apr 23, 2024
@stuartwdouglas stuartwdouglas force-pushed the STONEBLD-2371 branch 4 times, most recently from 10f2e51 to ed7235a Compare April 30, 2024 02:15
@stuartwdouglas
Copy link
Contributor Author

@psturc Can you have a look at this one please, and the associated PRs? It would be good to be able to get tests running on the multi platform controller repo.

Copy link
Member

@psturc psturc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stuartwdouglas lot of deprecated tests were removed from this repo, so please also rebase and then we can rerun the rehearsal, thank you!

@@ -485,6 +485,9 @@ func setRequiredEnvVars() error {
envVarPrefix = "MULTI_PLATFORM_CONTROLLER"
imageTagSuffix = "multi-platform-controller"
testSuiteLabel = "multi-platform"
im := strings.Split(os.Getenv("OTP_SERVER_IMAGE"), "@")
os.Setenv("MULTI_PLATFORM_CONTROLLER_OTP_IMAGE_REPO", im[0])
os.Setenv("MULTI_PLATFORM_CONTROLLER_OTP_IMAGE_TAG", im[1])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line needs to change to

if strings.HasSuffix(jobName, "-service-e2e") || strings.Contains(jobName, "controller-e2e") {

otherwise we'll never get to this code block in CI

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

magefiles/magefile.go Dismissed Show dismissed Hide dismissed
magefiles/magefile.go Dismissed Show dismissed Hide dismissed
Copy link

openshift-ci bot commented Jun 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kasemalem for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Jun 27, 2024

🚨 Error occurred while running the E2E tests, list of failed Spec(s):

  • ➡️ [failed] [It] [build-service-suite Build service E2E tests] test PaC component build when the component is removed and recreated (with the same name in the same namespace) should no longer lead to a creation of a PaC PR [build, HACBS, github-webhook, pac-build, pipeline, image-controller, build-custom-branch]
Expected success, but got an error:
    <*errors.errorString | 0xc000c965c0>: 
    error when deleting webhook: DELETE https://api.github.com/repos/redhat-appstudio-qe/devfile-sample-hello-world/hooks/486711032: 404 Not Found []
    {
        s: "error when deleting webhook: DELETE https://api.github.com/repos/redhat-appstudio-qe/devfile-sample-hello-world/hooks/486711032: 404 Not Found []",
    }

🙈 Link to Pod logs.
🙉 Link to Custom Resources.
🙊 Link to junit-summary.html.


@stuartwdouglas: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/redhat-appstudio-e2e 58fa20f link true /test redhat-appstudio-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants