Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change ITs pipelines to use EAS to provision clusters #1424

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: change ITs pipelines to use EAS to provision clusters #1424

wants to merge 1 commit into from
+217 −207

Conversation

flacatus
Copy link
Collaborator

Description

TSIA.

Issue ticket number and link

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

@openshift-ci openshift-ci bot requested review from cuipinghuo and jinqi7 October 11, 2024 10:15
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from flacatus. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@flacatus
Copy link
Collaborator Author

/retest

@flacatus flacatus changed the title Change pipelinesruns to use EAS to provision clusters feat: change pipelinesruns to use EAS to provision clusters Oct 11, 2024
@github-actions github-actions bot added 5-10 min and removed 1-5 min labels Oct 11, 2024
@flacatus flacatus force-pushed the eaas_ branch 2 times, most recently from 4310b35 to 72c9832 Compare October 11, 2024 11:49
@flacatus
Copy link
Collaborator Author

/retest

@flacatus
Copy link
Collaborator Author

/retest

@flacatus flacatus changed the title feat: change pipelinesruns to use EAS to provision clusters feat: change ITs pipelinesruns to use EAS to provision clusters Oct 11, 2024
@flacatus flacatus changed the title feat: change ITs pipelinesruns to use EAS to provision clusters feat: change ITs pipelines to use EAS to provision clusters Oct 11, 2024
@flacatus
Copy link
Collaborator Author

/retest

@flacatus
Copy link
Collaborator Author

/retest

Dannyb48
Dannyb48 reviewed Oct 11, 2024
View reviewed changes
Copy link
Contributor

@Dannyb48 Dannyb48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come we aren't updating our provision task in konflux-qe-defintions or creating a new provisioning task that leverages the step actions?

@flacatus flacatus force-pushed the eaas_ branch 2 times, most recently from 2fdaed2 to fe266d8 Compare October 18, 2024 23:30
@flacatus
Copy link
Collaborator Author

/retest

2 similar comments
@flacatus
Copy link
Collaborator Author

/retest

@flacatus
Copy link
Collaborator Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dannyb48 Dannyb48 Dannyb48 left review comments

@cuipinghuo cuipinghuo Awaiting requested review from cuipinghuo

@jinqi7 jinqi7 Awaiting requested review from jinqi7

Assignees
No one assigned
Labels
10-15 min
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flacatus @Dannyb48