fix: git repo url should have .git suffix #1480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This url is used in the RPA and it's used for Tekton git resolver. All the RPAs in konflux-release-data repo use the .git suffix and it's also what's used as an example in Tekton docs. For context, a user recently hit an issue: konflux-ci/release-service-catalog#759 We had a bug that caused an issue with the .git suffix. But e2e didn't expose the problem because the .git suffix was not there. Signed-off-by: Martin Malina <[email protected]>
Merged
4 tasks
johnbieren
approved these changes
Dec 20, 2024
|
/approve |
|
This file isn't in our directory so my approval doesn't count 🙃 |
psturc
approved these changes
Dec 20, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnbieren, psturc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
So sad 😭 @jinqi7 can you take a look please? |
This was referenced Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This url is used in the RPA and it's used for Tekton git resolver. All the RPAs in konflux-release-data repo use the .git suffix and it's also what's used
as an example in Tekton docs.
For context, a user recently hit an issue:
konflux-ci/release-service-catalog#759
We had a bug that caused an issue with the .git suffix. But e2e didn't expose the problem because the .git suffix was not there.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Issue ticket number and link
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: