[RFR] Application import: Verify assigned BS for imported application if BS already exists #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nandini Chandra <[email protected]>
nachandr
changed the title
Signed-off-by: Nandini Chandra <[email protected]>
Signed-off-by: Nandini Chandra <[email protected]>
Signed-off-by: Nandini Chandra <[email protected]>
Signed-off-by: Nandini Chandra <[email protected]>
nachandr
changed the title
abrugaro
approved these changes
Nov 27, 2024
Comment on lines
+82
to
+83
| it("Bug MTA-4257: 1)Applications import for non existing tags and BS \ | ||
| 2)Verify assigned BS for imported application if BS was created through previous import", function () { |
There was a problem hiding this comment.
Why are we testing 2 things in the same test case instead of having two different it?
There was a problem hiding this comment.
Thanks @abrugaro. These are long running tests, so I decided to combine the two to save some time . I've combined tests in the same it block for Assessment tests in the past . Test # 2 requires a few steps from test # 1.
One disadvantage to combining tests is that it does introduce some dependency.
|
Results from Jenkins run when PR was run on Tackle (off main branch):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.