[RFR] Limit analysis verifyStatus timeout to 10 mins #1289
Conversation
mguetta1
changed the title
| @@ -392,7 +393,7 @@ export class Analysis extends Application { | |||
|
|
|||
| public static verifyStatus(element: Cypress.Chainable, status: string) { | |||
| element | |||
| .find("div > div:nth-child(2)", { timeout: 3600000, log: false }) // 1h | |||
| .find("div > div:nth-child(2)", { timeout: 10 * MIN, log: false }) | |||
There was a problem hiding this comment.
Some large apps, such as those in ´load_analysis.test.ts´, can take more than 10 minutes to analyze.
You could increase the timeout to 30 minutes or add a default parameter to the verifyStatus method, which can be overridden as needed and set, at least, 30 mins for the apps under ´load_analysis.test.ts´.
There was a problem hiding this comment.
Thanks @abrugaro. 30 mins is way too much for an analysis in my opinion. In API tests (go-konveyor-tests repo) the max analysis duration is about 5-6 mins.
I will set the default to 10 mins and for any failure related to this change we will have to investigate if it is indeed a big app or a performance issue
There was a problem hiding this comment.
Sounds good!
In that case, could you please trigger a jenkins job to ensure the load_analysis tests does not break after this change?
There was a problem hiding this comment.
Sure thing, will do it
There was a problem hiding this comment.
Done.
@abrugaro I added the Jenkins run to the description
Signed-off-by: Maayan Hadasi <[email protected]>
mguetta1
force-pushed
the
analysis-timeout
branch
4 times, most recently
from
877e412 to
e327c92
Compare
Signed-off-by: Maayan Hadasi <[email protected]>
mguetta1
force-pushed
the
analysis-timeout
branch
from
e327c92 to
9673717
Compare
* Limit analysis verifyStatus timeout to 10 mins Signed-off-by: Maayan Hadasi <[email protected]> * Changes after review Signed-off-by: Maayan Hadasi <[email protected]> --------- Signed-off-by: Maayan Hadasi <[email protected]>
* Limit analysis verifyStatus timeout to 10 mins * Changes after review --------- Signed-off-by: Maayan Hadasi <[email protected]>
Resolves: https://issues.redhat.com/browse/MTA-4355
Relates to: https://issues.redhat.com/browse/MTA-4354
TIER0 Jenkins run: https://main-jenkins-csb-migrationqe.apps.ocp-c1.prod.psi.redhat.com/job/mta/job/mta-ui-tests-runner/4171/consoleFull
load_analysis.test.ts: https://main-jenkins-csb-migrationqe.apps.ocp-c1.prod.psi.redhat.com/job/mta/job/mta-ui-tests-runner/4183/console