🐛 Fix Targets (Rulesets) with repositories. #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Ortel <[email protected]>
jortel
force-pushed
the
ruleset-reposistory
branch
from
9c12535 to
6ec44d6
Compare
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
jortel
added
the
cherry-pick/release-0.5
github-actions bot
pushed a commit
that referenced
this pull request
Aug 1, 2024
https://issues.redhat.com/browse/MTA-3330 A custom target that references a repository will be created with a related `RuleSet`. A repository may be defined on the ruleSet. An analysis task defines _included_ labels which determine which rulesets are pulled (downloaded) from the hub. Since ruleSets that reference repositories do not have labels, the addon did not know to download it and clone the repository. Solution: The new rules.ruleSets will be used to pass a list of RuleSet (refs) selected by the user (by selecting targets). Each will be be unconditionally fetched by the addon. For each ruleset with a repository the addon will: - clone the repository - update .yaml files - replacing the `labels` element with `konveyor.io/include=always`. related: konveyor/tackle2-ui#2034 --------- Signed-off-by: Jeff Ortel <[email protected]> Signed-off-by: Cherry Picker <[email protected]>
|
I think the label on the rule set itself should fix the issue as it will be added to all rules in the rule set. Probably an optimization to come back too |
jortel
added a commit
that referenced
this pull request
Aug 1, 2024
https://issues.redhat.com/browse/MTA-3330 A custom target that references a repository will be created with a related `RuleSet`. A repository may be defined on the ruleSet. An analysis task defines _included_ labels which determine which rulesets are pulled (downloaded) from the hub. Since ruleSets that reference repositories do not have labels, the addon did not know to download it and clone the repository. Solution: The new rules.ruleSets will be used to pass a list of RuleSet (refs) selected by the user (by selecting targets). Each will be be unconditionally fetched by the addon. For each ruleset with a repository the addon will: - clone the repository - update .yaml files - replacing the `labels` element with `konveyor.io/include=always`. related: konveyor/tackle2-ui#2034 --------- Signed-off-by: Jeff Ortel <[email protected]> Signed-off-by: Cherry Picker <[email protected]> Signed-off-by: Jeff Ortel <[email protected]> Signed-off-by: Cherry Picker <[email protected]> Co-authored-by: Jeff Ortel <[email protected]>
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/MTA-3330
A custom target that references a repository will be created with a related
RuleSet. A repository may be defined on the ruleSet. An analysis task defines included labels which determine which rulesets are pulled (downloaded) from the hub. Since ruleSets that reference repositories do not have labels, the addon did not know to download it and clone the repository.Solution:
The new rules.ruleSets will be used to pass a list of RuleSet (refs) selected by the user (by selecting targets). Each will be be unconditionally fetched by the addon.
For each ruleset with a repository the addon will:
labelselement withkonveyor.io/include=always.related: konveyor/tackle2-ui#2034