🐛 Exclude non-required questionnaires in assessed calculation #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ibolton336 <[email protected]>
ibolton336
force-pushed
the
mta-1967-2
branch
from
b691113 to
9e1a64b
Compare
ibolton336
added
the
cherry-pick/release-0.3
sjd78
reviewed
Jan 19, 2024
| const assessmentQueries = useQueries({ | ||
| queries: archetypes.map((archetype) => ({ | ||
| queryKey: ["assessmentsForArchetype", archetype.id], | ||
| queryFn: () => getAssessmentsByItemId(true, archetype.id), // Replace with actual API call |
There was a problem hiding this comment.
Also, kinda a bummer we can't just send a single request to "get assessments for this list of archetype ids".
...p/pages/applications/components/application-detail-drawer/components/assessed-archetypes.tsx
Outdated
Show resolved
Hide resolved
...p/pages/applications/components/application-detail-drawer/components/assessed-archetypes.tsx
Outdated
Show resolved
Hide resolved
...p/pages/applications/components/application-detail-drawer/components/assessed-archetypes.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: ibolton336 <[email protected]>
Signed-off-by: ibolton336 <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Jan 26, 2024
Resolves https://issues.redhat.com/browse/MTA-1967 Addresses an issue where the assessed boolean for archetypes is set to true when all questionnaires are marked as not-required. Uses the new assessment.required boolean surfaced in konveyor/tackle2-hub@2552233 to filter out these false positives. --------- Signed-off-by: ibolton336 <[email protected]>
This was referenced Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://issues.redhat.com/browse/MTA-1967
Addresses an issue where the assessed boolean for archetypes is set to true when all questionnaires are marked as not-required. Uses the new assessment.required boolean surfaced in konveyor/tackle2-hub@2552233 to filter out these false positives.