Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Refactor table filterCategories definitions, rename the prop key to categoryKey #1800

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

rszwajko
Copy link
Collaborator

@rszwajko rszwajko commented Mar 27, 2024

Key prop is a special prop used internally by React.

@rszwajko rszwajko requested review from ibolton336 and sjd78 March 27, 2024 13:32
@sjd78
Copy link
Member

sjd78 commented Mar 27, 2024

Ah yeah - that's probably why PF5 uses value/children pairs now for dropdown/select/option lists

Key prop is a special prop in React.

Signed-off-by: Radoslaw Szwajkowski <[email protected]>
@rszwajko rszwajko changed the title : 🌱 Rename key property to categoryKey 🌱 Rename key property to categoryKey Mar 27, 2024
@rszwajko rszwajko changed the title 🌱 Rename key property to categoryKey 🌱 Rename key prop to categoryKey in IBasicFilterCategory Mar 27, 2024
@rszwajko rszwajko marked this pull request as ready for review March 27, 2024 22:28
@rszwajko rszwajko changed the title 🌱 Rename key prop to categoryKey in IBasicFilterCategory 🌱 Refactor table filterCategories definitions, rename the prop key to categoryKey Mar 27, 2024
Copy link
Member

@ibolton336 ibolton336 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjd78 sjd78 added this to the v0.4.0 milestone Mar 28, 2024
@ibolton336 ibolton336 merged commit 7f7375a into konveyor:main Mar 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants