🐛 Drop UTC offset for local time used in tasks table #1994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API provides date/time in UTC. For user convinience we display it in the browser time zone. Before this PR, UTC offset for the local time zone was included. The format used is a subset of ISO 8601 which allows for predictable sorting in the table. Format string: "YYYY-MM-DD HH:mm:ss". Example date: "2024-07-03 13:21:44". Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Before
After
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1994 +/- ##
==========================================
+ Coverage 39.20% 42.32% +3.12%
==========================================
Files 146 170 +24
Lines 4857 5434 +577
Branches 1164 1305 +141
==========================================
+ Hits 1904 2300 +396
- Misses 2939 3118 +179
- Partials 14 16 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Jul 10, 2024
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API provides date/time in UTC. For user convenience we display it in the browser time zone. Before this PR, UTC offset for the local time zone was included.
The format used is a subset of ISO 8601 which allows for predictable sorting in the table.
Format string: "YYYY-MM-DD HH:mm:ss".
Example date: "2024-07-03 13:21:44".
Part-of: #1969