🐛 Filter credentials by createUser property #2006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2006 +/- ##
==========================================
+ Coverage 39.20% 42.19% +2.99%
==========================================
Files 146 171 +25
Lines 4857 5479 +622
Branches 1164 1375 +211
==========================================
+ Hits 1904 2312 +408
- Misses 2939 3050 +111
- Partials 14 117 +103
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Drop conditional rendering as it clashes with column type definitions: the dynamic column is interpreted as optional property which is not allwed by the current typing in the table hooks. Co-authored-by: Ian Bolton <[email protected]> Signed-off-by: Radoslaw Szwajkowski <[email protected]>
rszwajko
force-pushed
the
credentialCreator
branch
from
f69ec0f to
f5c1e50
Compare
|
|
ibolton336
approved these changes
Jul 11, 2024
sjd78
approved these changes
Jul 11, 2024
1 task
1 task
This was referenced Jul 17, 2024
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop conditional rendering as it clashes with column type definitions:
the dynamic column is interpreted as optional property which is not
allowed by the current typing in the table hooks.
Resolves: https://issues.redhat.com/browse/MTA-3143
Co-authored-by: Ian Bolton [email protected]