1. DataStore: Change clone() function name to makeCopy() to avo…

…id reserved keywords `clone` in PHP 5.x
koolphp · Feb 15, 2019 · d56917a · d56917a
1 parent 7d697f3
commit d56917a
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Change Log
 
+## Version 3.25.4
+
+1. `DataStore`: Change `clone()` function name to `makeCopy()` to avoid reserved keywords `clone` in PHP 5.x
+
 ## Version 3.25.3
 
 1. `Table`: Fix Table warning in PHP 7.2+ when grouping is not set

diff --git a/README.md b/README.md
@@ -14,6 +14,7 @@
 
 # Changelog 
 
+* [Version 3.25.4 (Feb 15th, 2019)](https://www.koolreport.com/docs/koolreport/change_log/#version-3.25.4)
 * [Version 3.25.3 (Feb 14th, 2019)](https://www.koolreport.com/docs/koolreport/change_log/#version-3.25.3)
 * [Version 3.25.1 (Feb 13rd, 2019)](https://www.koolreport.com/docs/koolreport/change_log/#version-3.25.1)
 * [Version 3.25.0 (Feb 11st, 2019)](https://www.koolreport.com/docs/koolreport/change_log/#version-3.25.0)

diff --git a/composer.json b/composer.json
@@ -1,6 +1,6 @@
 {
     "name": "koolphp/koolreport",
-    "version":"3.25.3",
+    "version":"3.25.4",
     "description": "An Open Source PHP Reporting Framework for easier and faster report delivery.",
     "keywords": ["php reporting framework","php reporting tools","data processing","data visualization","charts and graphs"],
     "homepage": "https://www.koolreport.com",

diff --git a/src/core/DataStore.php b/src/core/DataStore.php
@@ -1159,11 +1159,11 @@ private function _mapKeyIndex($arr,$keys)
     }
 
     /**
-     * Map Key Index
+     * Make a copy of this datastore
      * 
      * @return DataStore The clone of this datastore
      */
-    public function clone()
+    public function makeCopy()
     {
         return new DataStore($this->rows, $this->metaData);
     }