Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New predicate support for where #376

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sachinpkale
Copy link

Add support for not between and similar to predicates.

Add support for important C3P0 configs.
Add convenient function for kylin DB.
Add cloverage plugin for test profile.

Sachin added 2 commits March 16, 2017 16:45
Add support for important C3P0 configs.
Add convenient function for kylin DB.
Add cloverage plugin for test profile.
Tests pending.
@AlexBaranosky
Copy link
Member

AlexBaranosky commented May 26, 2017

My 2 cents:

Make Korma easier to configure with the c3p0 --- and leave the c3p0 configuration to the user... don't attempt to wrap every c3p0 configuration, that's a waste of time/energy.

The way I configure my c3p0 pool at work is to just pull the pool off like (:datasource @(:pool db))

Then just call the java api on it like:

(.setCheckoutTimeout pool CONN_TIMEOUT)

@AlexBaranosky
Copy link
Member

This code imho should be two PRs -- it's two different changes smooshed into one branch.

@AlexBaranosky
Copy link
Member

AlexBaranosky commented May 26, 2017

Imho again: connection pool management by Korma is/was a mistake :) If there was ever going to be a Korma 1.0 -- I'd vote for removal of conn management from the api entirely. (Amen there probably should be by now, hehe -- nothing in the Clojure community ever makes it to 1.0.0 :) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants