feature: use keepalvied to add vip for virtual cluster #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
在deploy下面建一个目录，把keepalive的yaml传上去吧，不然代码开源不完整了 |
add keepalived manifest file in |
duanmengkk
reviewed
Jul 10, 2024
| topologyKey: "kubernetes.io/hostname" | ||
| initContainers: | ||
| - name: init-keepalived-config | ||
| image: {{ .ImageRepository }}/kubectl:v1.25.7-eki.3.0.0 |
There was a problem hiding this comment.
Suggested change
| image: {{ .ImageRepository }}/kubectl:v1.25.7-eki.3.0.0 | |
| image: {{ .ImageRepository }}/kubectl:v1.25.7 |
duanmengkk
reviewed
Jul 10, 2024
| advert_int 1 | ||
| authentication { | ||
| auth_type PASS | ||
| auth_pass Ae*vee1op@ahng5a |
There was a problem hiding this comment.
Suggested change
| auth_pass Ae*vee1op@ahng5a | |
| auth_pass XXXXXX |
There was a problem hiding this comment.
replace the auth_pass
duanmengkk
reviewed
Jul 10, 2024
Signed-off-by: wangdepeng <[email protected]>
|
resolve the conflicts |
|
this feature already in #689 , close this pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What does this PR do?
add vip for kube in kube for tenant cluster
Which issue(s) does this PR fix?
Fixes #635
Special notes for your reviewer:
Does this PR introduce a user-facing change?