-
-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: LoadingSnackBar consistently remains visible until the upload is complete #1533
base: main
Are you sure you want to change the base?
fix: LoadingSnackBar consistently remains visible until the upload is complete #1533
Conversation
… complete - Adjusted the `SendFileDialogState` file to ensure that the `showLoadingSnackBar` remains visible throughout the file upload process. - the SnackBar is cleared only after the image/file is uploaded and displayed in the chat.
This change addresses a UX issue where the loading SnackBar was not visible during critical operations like file compression and uploading, making the app appear frozen to the user. The root cause of this issue is the blocking of the main thread. For example:
Previously, the SnackBar was cleared and replaced multiple times (e.g., for preparing uploads, compressing, and uploading). This approach not only caused redundant updates but also compounded the blocking issue, making the UI seem unresponsive. To resolve this, the SnackBar now stays visible throughout the entire process, providing consistent feedback from start to finish. By not clearing and replacing it repeatedly, I ensure that the UI remains informative and responsive, giving users confidence that the app is working and their file will be uploaded successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine for me :) Thank you very much
@dohoanggiahuy317 Can you please sign your commit? |
… complete - Adjusted the `SendFileDialogState` file to ensure that the `showLoadingSnackBar` remains visible throughout the file upload process. - the SnackBar is cleared only after the image/file is uploaded and displayed in the chat. Signed-off-by: JaWeee <[email protected]>
…17/fluffychat into FluffyChat_JaWeee
Thank you so much for your approval! I’ve successfully signed the commit. Please let me know if there’s anything further I need to complete 😊 |
SendFileDialogState
file to ensure that theshowLoadingSnackBar
remains visible throughout the file upload process.Thank you so much for your contribution to FluffyChat ❤️❤️❤️
Please make sure that your Pull Request meet the following acceptance criteria:
dart format lib/ test/
anddart run import_sorter:main --no-comments
Pull Request has been tested on: