Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to check logs for all containers #15

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

markwinter
Copy link
Member

@markwinter markwinter commented Nov 1, 2021

Currently the Logs tab only shows logs for the kserve-container. For debugging it can be helpful to see the logs of other containers, especially the storage-initializer.

The current Logs tab also loads the logs of every component all at once.

The current Logs tab also uses LatestReadyRevision for checking logs. This means when the model server isn't in the ready state there will be no logs for debugging.

I have implemented a new tab system that lets the user check the logs for every init-container and container found for a pod.

I also changed it to check for LatestCreatedRevision as this is more useful. In the future I might try to add another row that lets the user select a specific revision to see its logs

Logs are also only loaded for the selected container.

image

@markwinter
Copy link
Member Author

@kimwnasptd

Can you review this please?

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: markwinter
To complete the pull request process, please assign yuzisun after the PR has been reviewed.
You can assign the PR to them by writing /assign @yuzisun in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markwinter markwinter force-pushed the all-container-logs branch 2 times, most recently from 5de7b44 to 483ab7e Compare December 23, 2021 03:06
Signed-off-by: Mark Winter <[email protected]>
@kimwnasptd
Copy link
Contributor

@markwinter I'm trying to rebase on top of the latest master, but I'm getting some merge conflicts.

Could you do one final rebase on top of the latest master?

@markwinter
Copy link
Member Author

@kimwnasptd Sorry for the long delay, this is now up to date with the latest master

@kimwnasptd
Copy link
Contributor

Thanks! Taking a look now

@kimwnasptd
Copy link
Contributor

@markwinter I think it's a good chance to use green threads for the backend, now that we will introduce requests that can take quite some time to wrap (like logs of the istio sidecar).

I wanted to move to gevent for the rest of the KF apps as well kubeflow/notebooks#107, so let's do the same here to be consistent. Can you update:

  1. The Makefile
  2. The dockerfile
  3. The requirements.txt

For installing/using gevent?

@StefanoFioravanzo
Copy link

Hey @markwinter thanks for the great contribution, exposing the logs from every component and container is definitely a very helpful feature.

I would suggest re-evaluating the UX of using nested tabs here, multiple nested tabs don't play that well together.

How about using a couple of select input fields instead? Something like this:
Screenshot 2022-06-28 at 14 23 49

What do you think?

@StefanoFioravanzo
Copy link

Also, I haven't read though the code carefully yet but I'll mention this: how are you retrieving the list of components and the list of containers? Is there some hardcoding going on or are you getting them from the CR? It's like to confirm that we are using the most dynamic approach as possible, in case we were to have new ISVC components or containers in the future.

@juliusvonkohout
Copy link
Contributor

@markwinter Please rebase to master

@markwinter
Copy link
Member Author

@juliusvonkohout Looks like been a few changes so I will get to rebasing this one some point soon.

@juliusvonkohout
Copy link
Contributor

@markwinter can you please rebase?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants