return grpc error with correct format #3

Vanient · 2023-06-26T04:02:47Z

fix #2

Signed-off-by: Vanient <[email protected]>

flyflypeng

Please provide more backgroud info in the commit info, like:
[module-name]: <short summary of commit info>
reason: <more detailed info about this commit>

flyflypeng

we need to make sure all errors in the grpc service function needed to be wrapped with tonic::Status

flyflypeng · 2023-06-27T02:41:52Z

crates/sandbox/src/rpc.rs

+                        tonic::Code::Internal,
+                        format!("failed to get sandbox {}, {}", req.sandbox_id, e),
+                    )
+                })?;
            let sandbox = sandbox_mutex.lock().await;
            sandbox.exit_signal().await?


Why this error doesn't need to do map_err processing?

return grpc error with correct format

c31a919

Signed-off-by: Vanient <[email protected]>

flyflypeng reviewed Jun 27, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

return grpc error with correct format #3

return grpc error with correct format #3

Vanient commented Jun 26, 2023

flyflypeng left a comment •

edited

Loading

flyflypeng left a comment

flyflypeng Jun 27, 2023

return grpc error with correct format #3

Are you sure you want to change the base?

return grpc error with correct format #3

Conversation

Vanient commented Jun 26, 2023

flyflypeng left a comment • edited Loading

Choose a reason for hiding this comment

flyflypeng left a comment

Choose a reason for hiding this comment

flyflypeng Jun 27, 2023

Choose a reason for hiding this comment

flyflypeng left a comment •

edited

Loading