Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use of SchemaGenerator for ZodGenerator #868

Merged
merged 4 commits into from
Mar 16, 2024

Conversation

stijnvanhulle
Copy link
Collaborator

No description provided.

Copy link

changeset-bot bot commented Mar 13, 2024

⚠️ No Changeset found

Latest commit: 0526fac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kubb ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 15, 2024 11:37pm

Copy link

codesandbox-ci bot commented Mar 13, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0526fac:

Sandbox Source
advanced-pet-store Configuration
faker-pet-store Configuration
msw-pet-store Configuration
python-pet-store Configuration
msw-v2-pet-store Configuration
react-query-pet-store Configuration
react-query-v5-pet-store Configuration
typescript-pet-store Configuration
simple-single-pet-store Configuration
solid-query-pet-store Configuration
svelte-query-pet-store Configuration
swr-pet-store Configuration
vue-query-pet-store Configuration
vue-query-v5-pet-store Configuration
zod-pet-store Configuration
zodios-pet-store Configuration
client-pet-store Configuration

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 81.84615% with 118 lines in your changes are missing coverage. Please review.

Project coverage is 78.12%. Comparing base (c346835) to head (0526fac).
Report is 1 commits behind head on main.

Files Patch % Lines
packages/swagger/src/SchemaGenerator.ts 75.69% 112 Missing and 1 partial ⚠️
packages/parser/src/factory.ts 80.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #868      +/-   ##
==========================================
+ Coverage   78.09%   78.12%   +0.03%     
==========================================
  Files         142      144       +2     
  Lines       13470    13553      +83     
  Branches     1503     1500       -3     
==========================================
+ Hits        10519    10588      +69     
- Misses       2939     2953      +14     
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stijnvanhulle stijnvanhulle merged commit 69b9e86 into main Mar 16, 2024
13 checks passed
@stijnvanhulle stijnvanhulle deleted the chore/SchemaGenerator branch March 16, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SchemaGenerator to combine logic for creating schemas for Typescript, Zod and Faker
1 participant