Add validation for uniqueness of nodepool-names #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mysticaltech
approved these changes
Oct 4, 2023
|
Yes, I tried it local with my project. |
mrclrchtr
force-pushed
the
NodepoolNameValidation
branch
from
dc772f9 to
c69bfd1
Compare
mrclrchtr
force-pushed
the
NodepoolNameValidation
branch
from
c69bfd1 to
74b11e6
Compare
|
Fixed the tf fmt errors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here: #539
I think it makes sense to do a check on uniqueness of names.