Add ederign as member #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathew Wicks <[email protected]>
|
@kimwnasptd can you please act as a second reference. |
|
@ederign +1 for adding Eder to Kubeflow. |
Signed-off-by: Mathew Wicks <[email protected]>
|
I realized I forgot to add him to the @kubeflow/red-hat team, so I have done that in 4449871 |
|
/lgtm |
tarilabs
reviewed
May 17, 2024
|
@andreyvelich I think we are good to merge this with your approval. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tarilabs, terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Welcome to the Kubeflow Community @ederign and thanks for your contributions 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds @ederign as a member.
He is a Red Hat employee that is assigned to Kubeflow.
He has been contributing significantly to the Notebooks 2.0 work (kubeflow/notebooks#85), and we would like to add him as a reviewer in some sub-directory of the new
kubeflow/notebooksrepo, so he needs to be a member of the org.He is also a mentor for the GSOC Kubeflow Notebook 2.0 project.
Most of his contributions are currently non-code (designing UI for Noteoboks 2.0), but I expect this will change, here is is current first PR: