Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add unit test for tune api #2410

Closed
wants to merge 54 commits into from
Closed

[WIP] Add unit test for tune api #2410

wants to merge 54 commits into from

Conversation

helenxie-bit
Copy link
Contributor

What this PR does / why we need it:
This PR adds unit test for tune API.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

@helenxie-bit
update tune api for llm hyperparameters optimization
2a882d7 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
resolve conflict
0c3e067 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
resolve conflict
158c8f3 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
fix the problem of dependency
f4a0d4e 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
fix the format of import statement
7e7dd56 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
adjust the blank lines
62ad385 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
delete the trainer to reuse it in Training Operator
3f36740 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
update constants
9d20253 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
update metrics format
dfbe793 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
update the type of and
290a249 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
update the message of 'ImportError'
aba2606 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
add TODO of PVC creation
eaf0193 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
update the name of pvc
62355a2 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
reuse constants from Training Operator
7b2b40e 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
keep 'parameters' and update validation
acd1dcf 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
update for test
10b057d 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
reuse 'get_container_spec' and 'get_pod_template_spec' from Training …
5a87eb0 
…Operator

Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
resolve conflicts
8387e67 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
format with black
71605b4 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
fix Lint error
35acedb 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
fix Lint errors
af534b3 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
delete types
c7f6e10 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
fix format
9fdbdb7 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
update format
ddd5153 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
update format
b31e820 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
fix e2e test error
dad3831 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
add TODO
1afe56d 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
format with max line length
ad7bce8 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
format docstring
7e58c94 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
update format
61dc8ca 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
fix typo
510661d 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
Merge remote-tracking branch 'origin/master' into helenxie/update_tun…
f03c5ba 
…e_api
@helenxie-bit
resolve conflicts and add check for case of no parameters
f6b15a2 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
fix format
6a3e046 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
fix format
25541b9 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
fix format
99e74d1 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
fix flake8 error
96cf99c 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
fix format
c568806 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
fix format
6f65253 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
fix format
ad17ac9 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
fix format
9a1e2df 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
add pytorchjob for tune api
421aaa6 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
fix format
bab4d92 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
add 'types' module
f11051d 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
add unit test for tune api
96768bc 
Signed-off-by: helenxie-bit <[email protected]>
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andreyvelich for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@helenxie-bit helenxie-bit changed the title Add unit test for tune api [GSoC] Add unit test for tune api Aug 19, 2024
@helenxie-bit
Copy link
Contributor Author

/area gsoc

@helenxie-bit
Copy link
Contributor Author

Ref: #2339

@helenxie-bit helenxie-bit mentioned this pull request Aug 19, 2024
Open
6 tasks
@helenxie-bit
fix format
3edfb49 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
fix format
6662ef7 
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit helenxie-bit changed the title [GSoC] Add unit test for tune api [WIP] Add unit test for tune api Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreyvelich andreyvelich Awaiting requested review from andreyvelich

@anencore94 anencore94 Awaiting requested review from anencore94

@gaocegege gaocegege Awaiting requested review from gaocegege

Assignees
No one assigned
Labels
area/gsoc do-not-merge/work-in-progress size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@helenxie-bit