Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade istio to v1.21.3 #2746

Merged
merged 5 commits into from
Jun 6, 2024
Merged

Conversation

biswajit-9776
Copy link
Contributor

Pull Request Template for Kubeflow manifests Issues

  • Please include a summary of changes and the related issue.
  • List any dependencies that are required for this change.
  • Please delete the options that are not relevant.
  • The following checklist will help you to satisfy the requirements.

✏️ A brief description of the changes

I upgraded istio from version 1.20.6 to 1.21.3

📦 List any dependencies that are required for this change

My PR depends on #

🐛 If this PR is related to an issue, please put the link of the issue here.

The following issues are related, because ...

✅ Unit Test Checklist

  • 🛠️ Make sure you have installed kustomize == 5.2.1+
  • ✍️ Have you written new tests for your core changes, as applicable?
  • 🔄 Have you successfully run existing tests with your changes ?
  • 🚀 Have you successfully run existing and new tests with your changes ?

✅ Contributor checklist


You can join our slack channel wg-manifests here. This link also contains our meeting schedule.

Signed-off-by: biswajit-9776 <[email protected]>
Signed-off-by: biswajit-9776 <[email protected]>
@juliusvonkohout
Copy link
Member

Please use this PR to finish your scripts. I want to use them myself for istio 1.22.

@google-oss-prow google-oss-prow bot added size/XXL and removed size/XL labels Jun 5, 2024
@biswajit-9776
Copy link
Contributor Author

biswajit-9776 commented Jun 5, 2024

The scripts are ready to be used after this PR is merged.
For now I haven't simplified their order of execution; so to upgrade istio, you would have to do the following:

  1. Have a kind cluster running which you can accomplish by running following command from manifests source directory.
kind create cluster --config tests/gh-actions/kind-cluster.yaml
  1. You would need to run sync-istio-manifests.sh first. It might ask for your sudo password in between and then just push the branch for a PR.
  2. After you have pushed the PR, you can now run the sync-istio-cni-manifests.sh.
  3. Push the branch again and it's done.

@rimolive
Copy link
Member

rimolive commented Jun 5, 2024

/lgtm

cc @juliusvonkohout

Signed-off-by: biswajit-9776 <[email protected]>
@google-oss-prow google-oss-prow bot removed the lgtm label Jun 5, 2024
@biswajit-9776
Copy link
Contributor Author

biswajit-9776 commented Jun 5, 2024

Sorry the script had a comment missing, which I have fixed now.

@juliusvonkohout
Copy link
Member

The scripts are ready to be used after this PR is merged.
For now I haven't simplified their order of execution; so to upgrade istio, you would have to do the following:

  1. Have a kind cluster running which you can accomplish by running following command from manifests source directory.
kind create cluster --config tests/gh-actions/kind-cluster.yaml
  1. You would need to run sync-istio-manifests.sh first. It might ask for your sudo password in between and then just push the branch for a PR.
  2. After you have pushed the PR, you can now run the sync-istio-cni-manifests.sh.
  3. Push the branch again and it's done.

Please get rid of sudo and Kind. We just want to synchronize the manifests as we do in the other scripts e.g. sync-kserve.

@rimolive
Copy link
Member

rimolive commented Jun 5, 2024

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jun 5, 2024
@juliusvonkohout
Copy link
Member

/approve
since @rimolive reviewed it. Ill try to update to istio 1.22 with the scripts next week.
@rimolive you can upgrade to 1.22 as well if you have time.

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit b46ce02 into kubeflow:master Jun 6, 2024
22 checks passed
@biswajit-9776
Copy link
Contributor Author

@rimolive Do let me know if the scripts fail in any way.

doncorsean pushed a commit to doncorsean/kubeflow-manifests that referenced this pull request Jul 18, 2024
* Upgrade istio to v1.21.3

Signed-off-by: biswajit-9776 <[email protected]>

* Upgraded istio-cni to v1.21.3

Signed-off-by: biswajit-9776 <[email protected]>

* Configured the scripts for istio-1.22.0

Signed-off-by: biswajit-9776 <[email protected]>

* Fixed the comment in script

Signed-off-by: biswajit-9776 <[email protected]>

* Removed sudo command and K8s requirement from scripts

Signed-off-by: biswajit-9776 <[email protected]>

---------

Signed-off-by: biswajit-9776 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants