Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove patching of istio; update values for seccompvalue via chart #2938

Open
wants to merge 4 commits into
base: istio-cni-by-default-with-seccomp-value
Choose a base branch
from

Conversation

MaxKavun
Copy link

@MaxKavun MaxKavun commented Dec 20, 2024

Pull Request Template for Kubeflow manifests Issues

✏️ A brief description of the changes

We should use the new "Values.gateways.seccompProfile" and securitycontext to get rid of the manual patch at
manifests/.github/workflows/pss_test.yaml

Lines 35 to 45 in 26d970d

 - name: Configure istio init container with seccompProfile attribute 
   run: | 
     kubectl get cm istio-sidecar-injector -n istio-system -o yaml > temporary_patch.yaml 
     sed -i '0,/runAsNonRoot: true/{s//&\n              seccompProfile:\n                type: RuntimeDefault/}' temporary_patch.yaml 
     sed -i '/runAsNonRoot: true/{N; /runAsUser: {{ .ProxyUID | default "1337" }}/a\ 
                   seccompProfile:\n                type: RuntimeDefault 
     }' temporary_patch.yaml 
     kubectl apply -f temporary_patch.yaml 
     rm temporary_patch.yaml 

both for istio and istio-cni, so it is related to #2528

📦 List any dependencies that are required for this change

My PR depends on #

🐛 If this PR is related to an issue, please put the link to the issue here.

The following issues are related, because ...

✅ Contributor checklist


You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kimwnasptd for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juliusvonkohout
Copy link
Member

I am on my phone, so there might be small mistakes.

@google-oss-prow google-oss-prow bot added size/XXL and removed size/S labels Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants