-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helm charts for training operator #2263
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Yi Chen <[email protected]>
Signed-off-by: Yi Chen <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold for review |
Pull Request Test Coverage Report for Build 10958395047Details
💛 - Coveralls |
This is great, thank you for this @ChenYi015! Additionally, how we can make sure that kustomize manifests and helm charts are maintained and in sync ? |
We need to pay massive maintaining costs to keep both HelmChart and kustomize. Hense, I do not think that this is maintainable. Based on my OSS experience, we often implement complex and unmaintainable conversion script. But, in this repository, I think that is not available based on community size. |
Agree. It is not a good idea to maintain a script or a tool to do sync between helm charts and kustomize. |
I think, we should discuss it in one of our upcoming Training WG calls. Maybe we can take a look at some examples on how users combine Helm and Kustomize together, for example: https://trstringer.com/helm-kustomize/. |
I actually maintain kustomize and Helm Chart in the Kueue repository. But the synchronization way was only a conversion shell script. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to huge maintenance overhead from my experience maintaining Argo's helm charts for a vendor.
One thing we can do is to have automation for maintenance, reduce parameterization, and have the Chart templates stay as close to the raw manifests as possible. Users can do their last-mile modification via kustomize's built-in helm chart support |
What this PR does / why we need it:
Add helm charts for training operator.
Which issue(s) this PR fixes :
Fixes #1197
Checklist: