Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Refactor ControlPlane contract #11285

Merged
merged 1 commit into from
Oct 18, 2024
Merged

📖 Refactor ControlPlane contract #11285

merged 1 commit into from
Oct 18, 2024

Conversation

fabriziopandini
Copy link
Member

@fabriziopandini fabriziopandini commented Oct 13, 2024 •
edited by sbueringer
Loading

What this PR does / why we need it:
This PR refactor the ControlPlane contract. Most notably

  • Everything related to the ControlPlane contract is now in one page,
  • There is a table that gives an overview of all the contract rules that applies to the InfraMachine
  • Duplicated informations about the ControlPlane contract have been removed from other pages

/area documentation

Part of #11105

@k8s-ci-robot k8s-ci-robot added area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 13, 2024
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 13, 2024
@fabriziopandini fabriziopandini mentioned this pull request Oct 13, 2024
Closed
59 tasks
@vincepri
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d5105db2b8efe71f44e4a9dd350e1ffa76f28941

@sbueringer
Copy link
Member

/assign

sbueringer
sbueringer reviewed Oct 15, 2024
View reviewed changes
docs/book/src/developer/core/controllers/cluster.md Outdated Show resolved Hide resolved
docs/book/src/developer/providers/contracts/bootstrap-config.md Outdated Show resolved Hide resolved
docs/book/src/developer/providers/contracts/control-plane.md Outdated Show resolved Hide resolved
docs/book/src/developer/providers/contracts/control-plane.md Outdated Show resolved Hide resolved
docs/book/src/developer/providers/contracts/control-plane.md Outdated Show resolved Hide resolved
docs/book/src/developer/providers/contracts/control-plane.md Outdated Show resolved Hide resolved
docs/book/src/developer/providers/contracts/control-plane.md Outdated Show resolved Hide resolved
docs/book/src/developer/providers/contracts/control-plane.md Outdated Show resolved Hide resolved
docs/book/src/developer/providers/contracts/control-plane.md Outdated Show resolved Hide resolved
docs/book/src/developer/providers/contracts/control-plane.md Outdated Show resolved Hide resolved
@fabriziopandini fabriziopandini force-pushed the refactor-control-plane-contract branch from 71d3ecb to 5792866 Compare October 15, 2024 19:20
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2024
sbueringer
sbueringer reviewed Oct 17, 2024
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last nit, feel free to squash directly

docs/book/src/developer/providers/contracts/control-plane.md Outdated Show resolved Hide resolved
@fabriziopandini fabriziopandini force-pushed the refactor-control-plane-contract branch from 5792866 to 6fc73d9 Compare October 17, 2024 21:56
@sbueringer
Copy link
Member

/lgtm
/approve

Thank you! Nice work on the contracts. Really a huge improvement

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d923f3dd05958a1105a998a4161b0919380d35e1

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2024
@k8s-ci-robot k8s-ci-robot merged commit d63d2ba into kubernetes-sigs:main Oct 18, 2024
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Oct 18, 2024
@fabriziopandini fabriziopandini deleted the refactor-control-plane-contract branch November 13, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@elmiko elmiko Awaiting requested review from elmiko

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@vincepri vincepri

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
4 participants
@fabriziopandini @vincepri @k8s-ci-robot @sbueringer