-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add v1beta2 conditions to ClusterClass #11428
🌱 Add v1beta2 conditions to ClusterClass #11428
Conversation
/hold |
e268298
to
8bb26c4
Compare
/hold cancel |
/test pull-cluster-api-e2e-main |
/assign @fabriziopandini @chrischdi |
internal/controllers/clusterclass/clusterclass_controller_status.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Stefan Büringer [email protected]
8bb26c4
to
b734c57
Compare
@fabriziopandini PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
/lgtm
/approve
LGTM label has been added. Git tree hash: a093c2dff47dcec9861952c4f056ab79be04b7c6
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Part of #11105