-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conformance tests for percentage-based request mirroring #3508
base: main
Are you sure you want to change the base?
conformance tests for percentage-based request mirroring #3508
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: LiorLieberman The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
117f34b
to
d63225c
Compare
d63225c
to
15db255
Compare
@LiorLieberman: GitHub didn't allow me to request PR reviews from the following users: jakebennert. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @LiorLieberman! This is really well done
/cc @dprotaso |
8ed94ce
to
aa266b3
Compare
aa266b3
to
63803d9
Compare
/cc @kflynn |
What type of PR is this?
/kind test
/area conformance
What this PR does / why we need it:
Conformance tests for #3171 plus small updates to the GEP.
Tested with istio 1.24.1
Note: I also added a test case for fraction but it looks like it has an issue currently with the implementation I used (istio).
The specific test is failing, (which is good) so I think its in a good merge state. I also opened istio/istio#54357.
Mesh tests to follow
Which issue(s) this PR fixes:
Fixes #3171
Does this PR introduce a user-facing change?:
/cc @jakebennert @robscott