Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update minCompatibilityVersion range. #5006

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update minCompatibilityVersion range. #5006

wants to merge 1 commit into from

Conversation

siyuanfoundation
Copy link
Contributor

  • One-line PR description:
    update minCompatibilityVersion range to make it more consistent and clear.
  • Other comments:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 18, 2024
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 18, 2024
@siyuanfoundation
Copy link
Contributor Author

/cc @jpbetz @Jefftree @aaron-prindle

@jpbetz
Copy link
Contributor

jpbetz commented Dec 18, 2024

/approve
/lgtm

Thanks for cleaning this up

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jpbetz, siyuanfoundation
Once this PR has been reviewed and has the lgtm label, please assign derekwaynecarr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aaron-prindle
Copy link

aaron-prindle commented Dec 18, 2024 •
edited
Loading

/lgtm

Thanks for the cleanup here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@dims dims Awaiting requested review from dims

@aaron-prindle aaron-prindle Awaiting requested review from aaron-prindle

@Jefftree Jefftree Awaiting requested review from Jefftree

@jpbetz jpbetz Awaiting requested review from jpbetz

Assignees

@jpbetz jpbetz

@aaron-prindle aaron-prindle

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@siyuanfoundation @jpbetz @k8s-ci-robot @aaron-prindle