Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloud Slack E2e Tests #1205

Merged
merged 7 commits into from
Sep 28, 2023
Merged

Cloud Slack E2e Tests #1205

merged 7 commits into from
Sep 28, 2023

Conversation

huseyinbabal
Copy link
Contributor

@huseyinbabal huseyinbabal commented Aug 23, 2023 •
edited
Loading

Description

Changes proposed in this pull request:

  • Introduced cloud-based slack e2e test

Testing

Related issue(s)

#865

@huseyinbabal huseyinbabal force-pushed the e2e-test-cloud branch 5 times, most recently from fa84bad to 3f83f22 Compare August 25, 2023 22:11
@huseyinbabal huseyinbabal marked this pull request as ready for review August 28, 2023 12:04
@huseyinbabal huseyinbabal requested review from a team and mszostok August 28, 2023 12:04
@huseyinbabal huseyinbabal mentioned this pull request Aug 28, 2023
Closed
5 tasks
@huseyinbabal huseyinbabal changed the title initial cloud e2e tests Cloud Slack E2e Tests Aug 28, 2023
mszostok
mszostok reviewed Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@mszostok mszostok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to revisit this copied code, as I see a lot of places where the code is 1:1, having 1,3k lines duplicated will introduce a big maintenance effort

helm/botkube/e2e-test-values.yaml Outdated Show resolved Hide resolved
test/botkubex/botkube_cli_helpers.go Outdated Show resolved Hide resolved
test/botkubex/botkube_cli_helpers.go Outdated Show resolved Hide resolved
test/commplatform/slack_tester.go Outdated Show resolved Hide resolved
test/e2e/bots_test.go Outdated Show resolved Hide resolved
test/e2e/bots_test.go Outdated Show resolved Hide resolved
@huseyinbabal huseyinbabal added the enhancement New feature or request label Sep 8, 2023
@huseyinbabal huseyinbabal force-pushed the e2e-test-cloud branch 4 times, most recently from 29dadad to eb8917f Compare September 18, 2023 10:02
@huseyinbabal huseyinbabal force-pushed the e2e-test-cloud branch 3 times, most recently from d98845e to 4c059f1 Compare September 25, 2023 10:40
mszostok
mszostok approved these changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@mszostok mszostok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it's awesome, good job! 🚀

test/e2e/bots_test.go Outdated Show resolved Hide resolved
test/e2e/bots_test.go Outdated Show resolved Hide resolved
test/e2e/bots_test.go Show resolved Hide resolved
test/e2e/bots_test.go Show resolved Hide resolved
test/e2e/bots_test.go Outdated Show resolved Hide resolved
test/e2e/bots_test.go Outdated Show resolved Hide resolved
test/e2e/bots_test.go Outdated Show resolved Hide resolved
test/e2e/bots_test.go Outdated Show resolved Hide resolved
@huseyinbabal
Copy link
Contributor Author

@mszostok thanks for your suggestions 🙏 addressed all of them, could you please briefly check them?

mszostok
mszostok approved these changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@mszostok mszostok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@huseyinbabal huseyinbabal merged commit 1cfd0cd into kubeshop:main Sep 28, 2023
15 checks passed
@huseyinbabal huseyinbabal deleted the e2e-test-cloud branch September 28, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mszostok mszostok mszostok approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huseyinbabal @mszostok