Typo Fix: in CONTRIBUTING.md #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszostok
reviewed
Sep 13, 2023
pkosiec
reviewed
Sep 15, 2023
cmd/cli/cmd/migrate.go
Outdated
| @@ -37,7 +37,7 @@ func NewMigrate() *cobra.Command { | |||
| Supported Botkube bot platforms for migration: | |||
| - Socket Slack | |||
| - Discord | |||
| - Mattermost | |||
| - Mattermost | |||
There was a problem hiding this comment.
Suggested change
| - Mattermost | |
| - Mattermost |
cmd/cli/docs/botkube_migrate.md
Outdated
| @@ -14,7 +14,7 @@ This command will create a new Botkube Cloud instance based on your existing Bot | |||
| Supported Botkube bot platforms for migration: | |||
| - Socket Slack | |||
| - Discord | |||
| - Mattermost | |||
| - Mattermost | |||
There was a problem hiding this comment.
Suggested change
| - Mattermost | |
| - Mattermost |
|
@sadath-12 please ping us once this PR is ready to review again 👍 |
|
@pkosiec Done , I have re-changed it to build the botkube named binary through command itself since while i was reading your docs in other places also there was mentioned to run botkube binary |
Signed-off-by: sadath-12 <[email protected]>
Signed-off-by: sadath-12 <[email protected]>
Signed-off-by: syedsadath-17 <[email protected]>
Signed-off-by: syedsadath-17 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1244 In order to run botkube binary we have to modify command to be
go build -o botkube ./cmd/botkube-agentin the CONTRIBUTING.md