Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show plugin activation status #1256

Merged
merged 10 commits into from
Sep 18, 2023
Merged

Conversation

josefkarasek
Copy link

Description

Changes proposed in this pull request:

  • @Botkube list sources|executors now prints status of each plugin with regards to plugin restarts.

image

Testing

Enable echo executor:

executors:
  echo:
    botkube/echo:
      enabled: true

Enable cm source:

sources:
  cm:
    displayName: "Kubernetes Config Map Watcher"
    botkube/cm-watcher:
      context: *default-plugin-context
      enabled: true
      config:
        configMap:
          name: watcher
          namespace: botkube
          event: ADDED

Restart cm and echo plugins with:

@Botkube echo @panic
apiVersion: v1
kind: ConfigMap
metadata:
  annotations:
    die: "true"
  name: watcher
  namespace: botkube

Check results with:

@Botkube list src
@Botkube list exec

Related issue(s)

#878

@josefkarasek josefkarasek requested review from a team and pkosiec September 13, 2023 13:33
@josefkarasek josefkarasek self-assigned this Sep 13, 2023
@josefkarasek josefkarasek added the enhancement New feature or request label Sep 13, 2023
@huseyinbabal huseyinbabal requested review from huseyinbabal and removed request for pkosiec September 15, 2023 08:34
return
}

status = pluginRunning
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe move it before line 65 and remove it here? seems obsolete to me

Copy link
Contributor

@huseyinbabal huseyinbabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, left one minor comment

@josefkarasek josefkarasek enabled auto-merge (squash) September 15, 2023 09:32
@josefkarasek josefkarasek merged commit 03a50c9 into kubeshop:main Sep 18, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants