Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic for Cloud Slack reconnect and JSON schema for K8s configuration #1264

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Fix panic for Cloud Slack reconnect and JSON schema for K8s configuration #1264

merged 2 commits into from
Sep 19, 2023

Conversation

pkosiec
Copy link
Collaborator

@pkosiec pkosiec commented Sep 18, 2023

Description

Changes proposed in this pull request:

  • Include default node message exclusion in JSON schema for K8s plugin
  • Fix panic for Cloud Slack reconnect

@pkosiec pkosiec added the bug Something isn't working label Sep 18, 2023
@pkosiec pkosiec added this to the v1.5.0 milestone Sep 18, 2023
@pkosiec pkosiec requested a review from PrasadG193 as a code owner September 18, 2023 10:45
@pkosiec pkosiec requested review from a team and huseyinbabal September 18, 2023 10:45
@mszostok mszostok requested review from mszostok and removed request for huseyinbabal September 18, 2023 12:32
mszostok
mszostok reviewed Sep 19, 2023
View reviewed changes
pkg/bot/slack_cloud_test.go Outdated Show resolved Hide resolved
internal/source/kubernetes/source.go Show resolved Hide resolved
pkg/bot/slack_cloud.go Outdated Show resolved Hide resolved
mszostok
mszostok reviewed Sep 19, 2023
View reviewed changes
pkg/bot/slack_cloud.go Outdated Show resolved Hide resolved
mszostok
mszostok approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@mszostok mszostok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested e2e, LGTM 👍

@pkosiec pkosiec merged commit 9e9ba87 into kubeshop:main Sep 19, 2023
14 checks passed
@pkosiec pkosiec deleted the fix-cloud-slack branch September 19, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mszostok mszostok mszostok approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
Botkube
Status: Done
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pkosiec @mszostok