Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ES type setting, add ES client logging, improve plugin URL err #1265

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

mszostok
Copy link
Collaborator

@mszostok mszostok commented Sep 19, 2023

Description

Changes proposed in this pull request:

  • Fix setting type for ES index
  • Add ES client logging
  • Improve plugin URL err

Testing

docker run --name opensearch --rm -d -p 9200:9200 -e http.port=9200 -e discovery.type=single-node -e http.max_content_length=10MB -e http.cors.enabled=true -e http.cors.allow-origin=\* -e http.cors.allow-headers=X-Requested-With,X-Auth-Token,Content-Type,Content-Length,Authorization -e http.cors.allow-credentials=true opensearchproject/opensearch:1.2.4

and open:

https://dejavu.reactivesearch.io/?appname=botkube-2023-09-19&url=https://admin:admin@localhost:9200&mode=edit

For ES you can also use the same UI.

Remember for OpenSearch to set the index.type to empty value:

communications:
  default-group:
    elasticsearch:
      server: https://localhost:9200
      username: 'admin'
      password: 'admin'
      skipTLSVerify: true
      enabled: true
      logLevel: "info" # can be one of: info,error,trace
      indices:
        'default':
          name: botkube
          type: ""
          shards: 1
          replicas: 0
          bindings:
            sources:
              - k8s-all-events
              - k8s-err-events
              - k8s-err-with-logs-events
              - k8s-create-events

Related issue(s)

Issue reported by user on https://botkube.slack.com/archives/C01CR1KS55K/p1693513948154599

@mszostok mszostok added the bug Something isn't working label Sep 19, 2023
@mszostok mszostok added this to the v1.5.0 milestone Sep 19, 2023
@mszostok mszostok requested review from a team and huseyinbabal September 19, 2023 10:42
@mszostok mszostok merged commit 8bdb6fc into kubeshop:main Sep 20, 2023
14 checks passed
@mszostok mszostok deleted the es branch September 20, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants