Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Cloud Slack Dev E2E tests and fix migration tests #1270

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Migrate Cloud Slack Dev E2E tests and fix migration tests #1270

merged 2 commits into from
Sep 26, 2023

Conversation

pkosiec
Copy link
Collaborator

@pkosiec pkosiec commented Sep 21, 2023 •
edited
Loading

Description

Changes proposed in this pull request:

  • Migrate Cloud Slack Dev E2E tests
  • Fix migration test

Testing

No need, CI tests both (see the branch build):

@pkosiec pkosiec added enhancement New feature or request ci Related to CI pipelines labels Sep 21, 2023
@pkosiec pkosiec force-pushed the cloud-slack-dev-e2e branch 3 times, most recently from 8260b08 to 2da15f3 Compare September 25, 2023 12:37
pkosiec
pkosiec commented Sep 26, 2023
View reviewed changes
.github/workflows/branch-build.yml Outdated Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
@pkosiec pkosiec added the bug Something isn't working label Sep 26, 2023
@pkosiec pkosiec changed the title Migrate Cloud Slack Dev E2E tests Migrate Cloud Slack Dev E2E tests and fix migration tests Sep 26, 2023
@pkosiec pkosiec marked this pull request as ready for review September 26, 2023 12:02
@pkosiec pkosiec requested a review from PrasadG193 as a code owner September 26, 2023 12:02
@pkosiec pkosiec requested review from a team and josefkarasek September 26, 2023 12:02
josefkarasek
josefkarasek approved these changes Sep 26, 2023
View reviewed changes
Copy link

@josefkarasek josefkarasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Well done!

@pkosiec pkosiec force-pushed the cloud-slack-dev-e2e branch from 08ea6c5 to d299736 Compare September 26, 2023 14:53
@pkosiec pkosiec merged commit 6c85373 into main Sep 26, 2023
14 checks passed
@pkosiec pkosiec deleted the cloud-slack-dev-e2e branch September 26, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josefkarasek josefkarasek josefkarasek approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
bug Something isn't working ci Related to CI pipelines enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pkosiec @josefkarasek