Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust app-releases button permission #4342

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

adjust app-releases button permission #4342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/shared/src/components/Apps/Applications/DetailInfo/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ function DetailInfo(): JSX.Element {
cardProps={{
name: getDisplayName(detail),
desc: detail?.description,
authKey: 'applications',
authKey: 'app-releases',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lingbohome Hello lingbohome! I have tried your solution, and seems it still works without modifying authkey, when a user is set to project-admin or workspace-admin. or I maybe overlook some cases?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason why I adjusted it to app-releases is that I saw that the authKey of other pages of this module was configured as app-releases, and the authKey of this module in the front-end configuration file was also configured as app-releases, and the back-end roletemplate, the front-end permissions of this module, were also configured as app-releases.
So I feel that it should be consistent with it?

icon: (
<Image
iconSize={32}
Expand All @@ -221,7 +221,7 @@ function DetailInfo(): JSX.Element {
),
attrs: getAttrs(),
actions: getActions(),
params: { workspace },
params: { cluster, workspace, namespace },
actionOptions: { theme: 'dark' },
breadcrumbs: {
label: t('APP_PL'),
Expand Down
Loading