Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix input annotation issue when creating a project #4358

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ROOMrepair
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it

In /workspace/*/projects, click "create" -> "advanced settings" and add some annotations. In the "key" input box ,the box will lose focus after typing in one character

2024-12-10.11.08.42.mov

Which issue(s) this PR fixes

Links #

Special notes for reviewers

none

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc


@ks-ci-bot
Copy link
Collaborator

@ROOMrepair: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot ks-ci-bot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed labels Dec 10, 2024
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ROOMrepair
To complete the pull request process, please assign zheng1 after the PR has been reviewed.
You can assign the PR to them by writing /assign @zheng1 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 10, 2024
@ROOMrepair ROOMrepair requested a review from donniean December 10, 2024 03:45
@ROOMrepair ROOMrepair closed this Dec 10, 2024
@ROOMrepair ROOMrepair reopened this Dec 10, 2024
@donniean
Copy link
Contributor

/test pull-console-build

@donniean
Copy link
Contributor

@ROOMrepair: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-console-build 5196d68 link /test pull-console-build
Full PR test history. Your PR dashboard.

@ROOMrepair

@ROOMrepair
Copy link
Contributor Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/release-note-label-needed kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants