Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update global variable handling in views to use decodeURIComponent #4383

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

yazhouio
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

fix: Update global variable handling in views to use decodeURIComponent

Which issue(s) this PR fixes:

Links #https://github.com/kubesphere/project/issues/5222
https://github.com/kubesphere/project/issues/4826

Special notes for reviewers:


Does this PR introduced a user-facing change?

none

Additional documentation, usage docs, etc.:


@ks-ci-bot ks-ci-bot added release-note-none kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 24, 2024
@yazhouio yazhouio requested a review from donniean December 24, 2024 06:26
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: donniean, yazhouio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 24, 2024
@donniean
Copy link
Contributor

/cherry-pick master

@ks-ci-bot
Copy link
Collaborator

@donniean: once the present PR merges, I will cherry-pick it on top of master in a new PR and assign it to you.

In response to this:

/cherry-pick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@donniean
Copy link
Contributor

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 24, 2024
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: e59d4b796facbf3335c348777a33152efa02f783

@ks-ci-bot ks-ci-bot merged commit 91b30dd into kubesphere:master Dec 24, 2024
5 checks passed
@ks-ci-bot
Copy link
Collaborator

@donniean: base branch (master) needs to differ from target branch (master)

In response to this:

/cherry-pick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@donniean
Copy link
Contributor

/cherry-pick release-4.1

@ks-ci-bot
Copy link
Collaborator

@donniean: new pull request created: #4385

In response to this:

/cherry-pick release-4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants