-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update global variable handling in views to use decodeURIComponent #4383
Conversation
Signed-off-by: ya zhou <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: donniean, yazhouio The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick master |
@donniean: once the present PR merges, I will cherry-pick it on top of master in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
LGTM label has been added. Git tree hash: e59d4b796facbf3335c348777a33152efa02f783
|
@donniean: base branch (master) needs to differ from target branch (master) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.1 |
@donniean: new pull request created: #4385 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
fix: Update global variable handling in views to use decodeURIComponent
Which issue(s) this PR fixes:
Links #https://github.com/kubesphere/project/issues/5222
https://github.com/kubesphere/project/issues/4826
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: