Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTV-1433 Rearranging prerequisites in the MTV user guide #591

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

RichardHoch
Copy link
Collaborator

@RichardHoch RichardHoch commented Nov 20, 2024

@RichardHoch RichardHoch changed the title WIP Rearranging prerequisites in the MTV user guide MTVC-1433 WIP Rearranging prerequisites in the MTV user guide Nov 25, 2024
@RichardHoch RichardHoch changed the title MTVC-1433 WIP Rearranging prerequisites in the MTV user guide MTV-1433 Rearranging prerequisites in the MTV user guide Nov 27, 2024
@RichardHoch RichardHoch marked this pull request as ready for review November 28, 2024 11:52
The configured file system overhead has a default value of 10%. If that is too low, the disk transfer fails due to lack of space. In this case, increase the file system overhead.

If you need to reduce storage consumption, decrease the file system overhead.

Copy link
Collaborator Author

@RichardHoch RichardHoch Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nunzy1 -- I changed lines 17-19 just now. Please review.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sentences are all good. :-) If the file system fails, they increase the overhead, as mentioned. The next sentence says that "if you need to reduce storage consumption," decrease the overhead. But, if I'm reading this right, if I decrease the overhead to reduce storage consumption, I risk the disk transfer failing. Do we tell them anywhere the scenario where they would decrease the overhead but not have the disk transfer fail?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mnecas @fabiand Please advise.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally would not recommend reducing that overhead as it could cause failed migrations, so I think we can remove that sentence. But I would highlight that this applies only for the volumes on the PVC with volumeMode Filesystem.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mnecas Changed.

@RichardHoch
Copy link
Collaborator Author

@nunzy1 I made many of the changes you suggested and did a little other rewriting. Please review this PR again. Thanks.

@RichardHoch RichardHoch requested a review from nunzy1 December 12, 2024 15:49
@RichardHoch RichardHoch requested a review from mnecas December 18, 2024 09:17
@RichardHoch
Copy link
Collaborator Author

@mnecas @fabiand Please review this PR. It is the 4th and final PR (hopefully) in the "restructure the user guide" epic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants