Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] CNV-23832: Apply StorageClass from Template's boot source #1532

Closed
wants to merge 1 commit into from

Conversation

avivtur
Copy link
Member

@avivtur avivtur commented Sep 12, 2023

📝 Description

When there's no StorageClass defined in the template or default StorageClass in the cluster, the CDI clone process can't determine which StorageClass to use and the DataVolume does not create its PersistentVolumeClaim.
If a template has an available boot source, we should apply the boot source's StorageClass if exist to allow VM to be created.

Note: This applies to the quick create flow for now, as we some issue with customize flow:

🎥 Demo

Before:

cant-clone.mp4

After:

clone-from-ds-pvc.mp4

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 12, 2023

@avivtur: This pull request references CNV-23832 which is a valid jira issue.

In response to this:

📝 Description

When there's no StorageClass defined in the template or default StorageClass in the cluster, the CDI clone process can't determine which StorageClass to use and the DataVolume does not create its PersistentVolumeClaim.
If a template has an available boot source, we should apply the boot source's StorageClass if exist to allow VM to be created.

Note: This applies to the quick create flow for now, as

🎥 Demo

Before:

cant-clone.mp4

After:

clone-from-ds-pvc.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from tnisan and upalatucci September 12, 2023 10:06
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Sep 12, 2023
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 12, 2023

@avivtur: This pull request references CNV-23832 which is a valid jira issue.

In response to this:

📝 Description

When there's no StorageClass defined in the template or default StorageClass in the cluster, the CDI clone process can't determine which StorageClass to use and the DataVolume does not create its PersistentVolumeClaim.
If a template has an available boot source, we should apply the boot source's StorageClass if exist to allow VM to be created.

Note: This applies to the quick create flow for now, as we some issue with customize flow:

🎥 Demo

Before:

cant-clone.mp4

After:

clone-from-ds-pvc.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metalice
Copy link
Member

this is a partial fix? not fixing customize flow ?

@avivtur avivtur changed the title CNV-23832: Apply StorageClass from Template's boot source [WIP] CNV-23832: Apply StorageClass from Template's boot source Sep 13, 2023
@avivtur avivtur force-pushed the apply-boot-source-sc branch from 7729ed6 to ec724b8 Compare October 11, 2023 08:44
@avivtur
Copy link
Member Author

avivtur commented Oct 11, 2023

@metalice Currently this PR is using the first SC it finds from the list (as the 4.15 cluster has volume snapshots and not PVC) we should figure out a way to get the SC from the boot source or simply use the first one as I do currently.
BTW this functionality will exist only in UI

@avivtur avivtur closed this Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants