-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] CNV-23832: Apply StorageClass from Template's boot source #1532
Conversation
@avivtur: This pull request references CNV-23832 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@avivtur: This pull request references CNV-23832 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
this is a partial fix? not fixing customize flow ? |
src/views/catalog/templatescatalog/components/TemplatesCatalogDrawer/utils/helpers.ts
Outdated
Show resolved
Hide resolved
...alog/templatescatalog/components/TemplatesCatalogDrawer/TemplatesCatalogDrawerCreateForm.tsx
Show resolved
Hide resolved
Signed-off-by: Aviv Turgeman <[email protected]>
7729ed6
to
ec724b8
Compare
@metalice Currently this PR is using the first SC it finds from the list (as the 4.15 cluster has volume snapshots and not PVC) we should figure out a way to get the SC from the boot source or simply use the first one as I do currently. |
📝 Description
When there's no StorageClass defined in the template or default StorageClass in the cluster, the CDI clone process can't determine which StorageClass to use and the DataVolume does not create its PersistentVolumeClaim.
If a template has an available boot source, we should apply the boot source's StorageClass if exist to allow VM to be created.
Note: This applies to the quick create flow for now, as we some issue with customize flow:
🎥 Demo
Before:
cant-clone.mp4
After:
clone-from-ds-pvc.mp4