CNV-53287: fix the alignment issue on Settings -> User #2320
Conversation
|
@gouyang: This pull request references CNV-53287 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| @@ -14,7 +14,7 @@ const TaskPermissionsSection: FC = () => { | |||
| const { t } = useKubevirtTranslation(); | |||
| const { capabilitiesData, isLoading } = usePermissions(); | |||
| return ( | |||
| <ExpandSection className="permissions-tab--main" toggleText={t('Permissions')}> | |||
| <ExpandSection toggleText={t('Permissions')}> | |||
There was a problem hiding this comment.
please check if the class permissions-tab--main isnt needed anymore and if so delete it as well, no need for unused classes
There was a problem hiding this comment.
it's only used here, it looks fine to me by removing it just here.
src]# grep "permissions-tab--main" $(find . -type f)
grep: ./utils/components/HardwareDevices/list/hooks/useHardwareDevicesPageColumns: No such file or directory
grep: .tsx: No such file or directory
./views/clusteroverview/SettingsTab/UserTab/components/TaskPermissionsSection/TaskPermissionsSection.tsx: <Divider className="permissions-tab--main__divider" />
./views/clusteroverview/SettingsTab/UserTab/components/TaskPermissionsSection/TaskPermissionsSection.tsx: <Flex className="permissions-tab--main__row" key={taskName}>
|
@gouyang: This pull request references CNV-53287 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gouyang, lkladnit, metalice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Before:
After: