Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sig,badges: Add total number of jobs run per SIG to each SIG badge #67

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

brianmcarey
Copy link
Member

What this PR does / why we need it:

The number of failed runs per SIG does not give a clear picture on its own without the total number of job runs per SIG as each SIG has a different number of lanes that runs against each PR.

This includes the total number of jobs run per SIG in each SIG badge and sets the badge colour to reflect the percentage of failed jobs out of total jobs run.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #66

Special notes for your reviewer:

/cc @dhiller @xpivarc

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:


The number of failed runs per SIG does not give a clear picture on its
own without the total number of job runs per SIG as each SIG has a
different number of lanes that runs against each PR.

This includes the total number of jobs run per SIG in each SIG badge and
sets the badge colour to reflect the percentage of failed jobs out of
total jobs run.

Signed-off-by: Brian Carey <[email protected]>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M labels Sep 10, 2024
Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@dhiller dhiller merged commit 08ee6e2 into main Sep 12, 2024
2 checks passed
@dhiller dhiller deleted the sig-badge-total-relative branch September 12, 2024 13:36
@xpivarc
Copy link
Member

xpivarc commented Sep 12, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display total lane runs in SIG failures badge
4 participants