Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sig,badges: Include the percentage failure rate in SIG and lane badges #70

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

brianmcarey
Copy link
Member

What this PR does / why we need it:

Currently the SIG and e2e lane badges only display the absolute number
of failures vs. the total number of lanes run.

Including the percentage failure rate is also useful information to stop
users from having to calculate that themselves.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/cc @dhiller @xpivarc

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:


Signed-off-by: Brian Carey <[email protected]>
Currently the SIG and e2e lane badges only display the absolute number
of failures vs. the total number of lanes run.

Including the percentage failure rate is also useful information to stop
users from having to calculate that themselves.

Signed-off-by: Brian Carey <[email protected]>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/S labels Oct 1, 2024
Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Makes total sense 👍

@dhiller dhiller merged commit 30f618a into main Oct 2, 2024
2 checks passed
@dhiller dhiller deleted the lane-percentages branch October 2, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants