Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gather_nodes execution with multiple images #215

Merged
merged 1 commit into from
May 28, 2024

Conversation

tiraboschi
Copy link
Member

POD_NAME is already available out of the box as
an env variable via downwardAPIs, no need to introspect it from the list of running pods.
POD_NAME introspection is currently broken when
multiple images are executed in parallel.

Fixes: https://issues.redhat.com/browse/CNV-41537

Release note:

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 27, 2024
@openshift-ci openshift-ci bot requested review from machadovilaca and orenc1 May 27, 2024 15:45
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2024
@kubevirt-bot kubevirt-bot requested a review from nunnatsa May 27, 2024 15:46
POD_NAME is already available out of the box as
an env variable via downwardAPIs, no need to introspect
it from the list of running pods.
POD_NAME introspection is currently broken when
multiple images are executed in parallel.

Signed-off-by: Simone Tiraboschi <[email protected]>
Copy link
Collaborator

@nunnatsa nunnatsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2024
@kubevirt-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented May 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa, tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [nunnatsa,tiraboschi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot merged commit dcab06c into kubevirt:main May 28, 2024
6 checks passed
@tiraboschi tiraboschi deleted the pod_name branch May 28, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants