Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move root CI lanes to 1.31 #3841

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rthallisey
Copy link
Contributor

What this PR does / why we need it:
Move Root CI lanes to 1.31 k8s provider

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

Release note:

NONE

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Dec 18, 2024
@rthallisey
Copy link
Contributor Author

@dhiller, does this look right?

Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rthallisey - thanks for the PR.

We won't require the changes to the release branches as those will have older kubevirtci versions so these changes can be dropped

Just need to focus on jobs on the main branch so the changes in github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/kubevirt-presubmits.yaml look good.

There are some periodic lanes that run against main which will need to be bumped -

name: periodic-kubevirt-e2e-k8s-1.29-sig-storage-root

@brianmcarey
Copy link
Member

/rehearse ?

@kubevirt-bot
Copy link
Contributor

Rehearsal is available for the following jobs in this PR:

pull-kubevirt-e2e-k8s-1.31-sig-compute-root-1.2
pull-kubevirt-e2e-k8s-1.31-sig-storage-root-1.2
pull-kubevirt-e2e-k8s-1.31-sig-compute-root-1.3
pull-kubevirt-e2e-k8s-1.31-sig-storage-root-1.3
pull-kubevirt-e2e-k8s-1.31-sig-compute-root-1.4
pull-kubevirt-e2e-k8s-1.31-sig-storage-root-1.4
pull-kubevirt-e2e-k8s-1.31-sig-compute-root
pull-kubevirt-e2e-k8s-1.31-sig-storage-root

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

@brianmcarey
Copy link
Member

/rehearse pull-kubevirt-e2e-k8s-1.31-sig-compute-root
/rehearse pull-kubevirt-e2e-k8s-1.31-sig-storage-root

@kubevirt-bot
Copy link
Contributor

Rehearsal jobs created for this PR:

rehearsal-pull-kubevirt-e2e-k8s-1.31-sig-compute-root
rehearsal-pull-kubevirt-e2e-k8s-1.31-sig-storage-root

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

@dhiller
Copy link
Contributor

dhiller commented Dec 19, 2024

The failure we see on the sig-storage-root lane is known - we see the same on the periodic.

@dhiller
Copy link
Contributor

dhiller commented Dec 19, 2024

@rthallisey sorry, forgot to mention that the periodic root lanes need the same bumping:

Signed-off-by: Ryan Hallisey <[email protected]>
@dhiller
Copy link
Contributor

dhiller commented Dec 20, 2024

/rehearse

@kubevirt-bot
Copy link
Contributor

Rehearsal jobs created for this PR:

rehearsal-pull-kubevirt-e2e-k8s-1.31-sig-storage-root
rehearsal-pull-kubevirt-e2e-k8s-1.31-sig-compute-root

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/hold to be removed if the rehearsals only show the usual behavior.

@kubevirt-bot kubevirt-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Dec 20, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2024
@brianmcarey
Copy link
Member

/rehearse

@kubevirt-bot
Copy link
Contributor

Rehearsal jobs created for this PR:

rehearsal-pull-kubevirt-e2e-k8s-1.31-sig-storage-root
rehearsal-pull-kubevirt-e2e-k8s-1.31-sig-compute-root

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

@rthallisey
Copy link
Contributor Author

/rehearse

@kubevirt-bot
Copy link
Contributor

⚠️ @rthallisey you need to be an approver for all the files to run rehearsal.

@acardace can help run the rehearsal.

If that doesn't work, ping someone from this list:

  • davidvossel
  • dhiller
  • enp0s3
  • phoracek
  • tiraboschi
  • xpivarc
  • aglitke
  • brianmcarey
  • rmohr
  • vladikr

@brianmcarey
Copy link
Member

/rehearse

@kubevirt-bot
Copy link
Contributor

Rehearsal jobs created for this PR:

rehearsal-pull-kubevirt-e2e-k8s-1.31-sig-storage-root
rehearsal-pull-kubevirt-e2e-k8s-1.31-sig-compute-root

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

@kubevirt-bot
Copy link
Contributor

@rthallisey: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-project-infra-lint c2d5986 link true /test pull-project-infra-lint
rehearsal-pull-kubevirt-e2e-k8s-1.31-sig-storage-root 53950a6 link unknown /test pull-kubevirt-e2e-k8s-1.31-sig-storage-root
rehearsal-pull-kubevirt-e2e-k8s-1.31-sig-compute-root 53950a6 link unknown /test pull-kubevirt-e2e-k8s-1.31-sig-compute-root

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants