-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add export PLATFORMS=all to post-submit jobs for kubemacpool. #3855
base: main
Are you sure you want to change the base?
Add export PLATFORMS=all to post-submit jobs for kubemacpool. #3855
Conversation
This update ensures that the PLATFORMS environment variable is set to "all" before executing the `make container docker-push` . This change enables building multi-platform images for kubemacpool cni. Signed-off-by: Ashok Pariya <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @ashokpariya0. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
This PR should be merged before the other KMP PR, right ?
No biggie, but i think it is better
We can go ahead and merge this PR. |
up to Ram |
afterwards i believe you would like a release |
Yes, and we can use the released tagged images in CNAO. |
This update ensures that the PLATFORMS environment variable is set to "all" before executing the
make container docker-push
. This change enables building multi-platform images for kubemacpool cni.What this PR does / why we need it:
Currently, we are only posting an amd64-supported image for the Kubemacpool CNI: link to image.
To build a multi-platform image that supports amd64, arm64, and s390x, the PLATFORMS=all environment variable must be exported before running the make container command.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: