Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add export PLATFORMS=all to post-submit jobs for kubemacpool. #3855

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ashokpariya0
Copy link
Contributor

This update ensures that the PLATFORMS environment variable is set to "all" before executing the make container docker-push . This change enables building multi-platform images for kubemacpool cni.

What this PR does / why we need it:
Currently, we are only posting an amd64-supported image for the Kubemacpool CNI: link to image.

To build a multi-platform image that supports amd64, arm64, and s390x, the PLATFORMS=all environment variable must be exported before running the make container command.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:


This update ensures that the PLATFORMS environment variable is set to "all"
before executing the `make container docker-push` . This change enables
building multi-platform images for kubemacpool cni.

Signed-off-by: Ashok Pariya <[email protected]>
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Dec 23, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign phoracek for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot
Copy link
Contributor

Hi @ashokpariya0. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@oshoval oshoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
This PR should be merged before the other KMP PR, right ?
No biggie, but i think it is better

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 23, 2024
@ashokpariya0
Copy link
Contributor Author

Thanks This PR should be merged before the other KMP PR, right ? No biggie, but i think it is better

We can go ahead and merge this PR.

@oshoval
Copy link
Contributor

oshoval commented Dec 23, 2024

up to Ram
Thanks

@oshoval
Copy link
Contributor

oshoval commented Dec 23, 2024

afterwards i believe you would like a release

@ashokpariya0
Copy link
Contributor Author

afterwards i believe you would like a release

Yes, and we can use the released tagged images in CNAO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants